Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ci/tests): use awvwgk/setup-fortran, use pytest tempdirs #136

Merged
merged 1 commit into from
Jul 28, 2023
Merged

refactor(ci/tests): use awvwgk/setup-fortran, use pytest tempdirs #136

merged 1 commit into from
Jul 28, 2023

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Jul 25, 2023 •
edited
Loading

  • switch to awvwgk/setup-fortran to install Intel compilers
    • temporarily set SETVARS_COMPLETED and CXX manually until action patched
  • use pytest temp dir fixtures in autotests
  • add pytest-dependency to test dep group in pyproject.toml
  • add dependency marker to autotest/pytest.ini to avoid warnings

@wpbonelli wpbonelli marked this pull request as draft July 25, 2023 12:41
@codecov
Copy link

codecov bot commented Jul 25, 2023 •
edited
Loading

Codecov Report

Merging #136 (6ea01d1) into master (8f804f9) will decrease coverage by 4.371%.
The diff coverage is n/a.

❗ Current head 6ea01d1 differs from pull request most recent head 57063ea. Consider uploading reports for the commit 57063ea to get more accurate results

@@              Coverage Diff              @@
##            master      #136       +/-   ##
=============================================
- Coverage   73.513%   69.143%   -4.371%     
=============================================
  Files           20        20               
  Lines         3432      3432               
=============================================
- Hits          2523      2373      -150     
- Misses         909      1059      +150

see 7 files with indirect coverage changes

@wpbonelli wpbonelli force-pushed the test-make-mf6 branch 13 times, most recently from 88878b5 to 48a35fe Compare July 27, 2023 19:46
@wpbonelli
test: use pytest temporary directories in autotests
57063ea 
* switch to awvwgk/setup-fortran in CI
* set CXX and SETVARS_COMPLETED manually until setup-fortran patched
* add pytest-dependency to test dependency group in pyproject.toml
* add dependency marker to autotest/pytest.ini to avoid warnings
@wpbonelli wpbonelli marked this pull request as ready for review July 28, 2023 16:44
jdhughes-usgs
jdhughes-usgs approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@jdhughes-usgs jdhughes-usgs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this PR cleans up the CI tests

@jdhughes-usgs jdhughes-usgs merged commit 3bf53a2 into modflowpy:master Jul 28, 2023
15 checks passed
@wpbonelli wpbonelli deleted the test-make-mf6 branch July 29, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhughes-usgs jdhughes-usgs jdhughes-usgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpbonelli @jdhughes-usgs